[GitHub] flink pull request #6031: [FLINK-9386] Embed netty router

[uce]

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6031#discussion_r190246117
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
 ---
    @@ -89,19 +91,20 @@ public RuntimeMonitorHandler(
        }
     
        @Override
    -   protected void respondAsLeader(ChannelHandlerContext ctx, Routed 
routed, JobManagerGateway jobManagerGateway) {
    +   protected void respondAsLeader(ChannelHandlerContext ctx, RoutedRequest 
routedRequest, JobManagerGateway jobManagerGateway) {
                CompletableFuture<FullHttpResponse> responseFuture;
    +           RouteResult result = routedRequest.getRouteResult();
    --- End diff --
    
    I think if you do `RouteResult<?> result = routedRequest.getRouteResult();` 
you don't need the cast to `Set<String>` in lines 101 and 106.


---