[
https://issues.apache.org/jira/browse/FLINK-9386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487419#comment-16487419
]
ASF GitHub Bot commented on FLINK-9386:
---------------------------------------
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6031
Thanks for the review and manual checks! I either addressed your comments
in fixup commit and left comment responses otherwise.
> Do we file a follow up ticket to remove netty-router from our shaded
Netty? Optionally, we might consider adding an import suppression for
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.router.* to guard
against any accidental usage until we remove the dependency.
I planned to upgrade netty and drop netty-router in one step of upgrading
`flink-shaded-netty`. Do you think it should be split somehow?
> I don't know what your opinion is on cleaning up the copied classes. I'm
OK with keeping everything as is, but I get a bunch of minor/trivial warnings
about the code (like code visibility, unchecked calls, unused variables, etc.).
I understand if we want to stay close to the copied classes.
I would be open to clean it up as we think it's best. I do not see a point
in maintaining compatibility with the original sources. If you have other such
comments, please feel free to write them.
> Remove netty-router dependency
> ------------------------------
>
> Key: FLINK-9386
> URL: https://issues.apache.org/jira/browse/FLINK-9386
> Project: Flink
> Issue Type: Sub-task
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Fix For: 1.6.0
>
>
> netty-router 1.10 blocks upgrade to 4.1, while netty-router 2.2.0 has broken
> compatibility in a way that it's unusable by us (it doesn't allow to sort
> router paths as in https://issues.apache.org/jira/browse/FLINK-8000 ). I
> propose to copy & simplify & modify netty-router code to suite our needs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
