[
https://issues.apache.org/jira/browse/FLINK-8511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488801#comment-16488801
]
ASF GitHub Bot commented on FLINK-8511:
---------------------------------------
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6055
Thank you @kisimple. The PR looks good.
We can also remove the `jcl-over-slf4j` dependency and update the
`dependencyManagement` section. But I will do this and merge this after testing.
> Remove legacy code for the TableType annotation
> -----------------------------------------------
>
> Key: FLINK-8511
> URL: https://issues.apache.org/jira/browse/FLINK-8511
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: Timo Walther
> Assignee: blues zheng
> Priority: Critical
>
> We introduced the very generic TableSource factories that unify the
> definition of table sources and are specified using Java service loaders. For
> backwards compatibility, the old code paths are still supported but should be
> dropped in future Flink versions.
> This will touch:
> {code}
> org.apache.flink.table.annotation.TableType
> org.apache.flink.table.catalog.ExternalCatalogTable
> org.apache.flink.table.api.NoMatchedTableSourceConverterException
> org.apache.flink.table.api.AmbiguousTableSourceConverterException
> org.apache.flink.table.catalog.TableSourceConverter
> org.apache.flink.table.catalog.ExternalTableSourceUtil
> {code}
> We can also drop the {{org.reflections}} and {{commons-configuration}} (and
> maybe more?) dependencies.
> See also FLINK-8240
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
