[ 
https://issues.apache.org/jira/browse/FLINK-8468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490786#comment-16490786
 ] 

ASF GitHub Bot commented on FLINK-8468:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r190654087
  
    --- Diff: 
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
 ---
    @@ -151,7 +151,9 @@ public void open(Configuration config) throws Exception 
{
                        if (channel == null) {
                                throw new RuntimeException("None of RabbitMQ 
channels are available");
                        }
    -                   setupQueue();
    +                   if (rmqConnectionConfig.hasToCreateQueueOnSetup()) {
    --- End diff --
    
    There was a PR that did something similar and got rejected. See: 
https://github.com/apache/flink/pull/4979 and 
https://issues.apache.org/jira/browse/FLINK-8018


> Make the connector to take advantage of AMQP features (routing key, exchange 
> and message properties)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8468
>                 URL: https://issues.apache.org/jira/browse/FLINK-8468
>             Project: Flink
>          Issue Type: Improvement
>          Components: RabbitMQ Connector
>    Affects Versions: 1.4.0
>            Reporter: Ph.Duveau
>            Priority: Major
>
> Make the connector to take advantage of AMQP features by adding a constructor 
> and an interface to implement



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to