[
https://issues.apache.org/jira/browse/FLINK-9530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502947#comment-16502947
]
ASF GitHub Bot commented on FLINK-9530:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6126
[FLINK-9530][metrics] Fix numRecords task metric for chains
## What is the purpose of the change
This PR fixes the task re-use of operator `numRecordsIn/Out` metrics. Tasks
were re-using both metrics for all operators in a chain, such that
`numRecordsIn` for a task was the sum of `numRecordsIn` over all operators.
This was caused due to a copy&paste error in a previous refactoring. The
removed lines in `ChainingOutput` are entirely unnecessary as the re-use is
completely handled by `AbstractStreamOperator#setup`.
## Brief change log
* remove faulty code from `ChainingOutput`
* add tests
## Verifying this change
* see added tests in `OneInputStreamTaskTest` and `TwoInputStreamTaskTest`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9530
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6126
----
commit cb47df38e72caef557749baee0d8a21ad29ac1ab
Author: zentol <chesnay@...>
Date: 2018-06-05T13:01:10Z
[FLINK-9530][metrics] Fix numRecords task metric for chains
----
> Task numRecords metrics broken for chains
> -----------------------------------------
>
> Key: FLINK-9530
> URL: https://issues.apache.org/jira/browse/FLINK-9530
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.6.0, 1.5.1
>
>
> The {{numRecordsIn/Out}} metrics for tasks is currently broken. We are
> wrongly adding up the numRecordsIn/Out metrics for all operators in the
> chain, instead of just the head/tail operators.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
