[GitHub] flink pull request #6071: [FLINK-3952][runtine] Upgrade to Netty 4.1

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6071#discussion_r194652495
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/ChunkedByteBuf.java
 ---
    @@ -88,6 +102,16 @@ public ByteBuf readChunk(ChannelHandlerContext ctx) 
throws Exception {
                }
        }
     
    +   @Override
    +   public long length() {
    +           return length;
    --- End diff --
    
    Is it always guaranteed that `buf.readableBytes` won't change? If not, then 
I think we should return `-1` here, because the length is unknown.


---