[
https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509384#comment-16509384
]
ASF GitHub Bot commented on FLINK-3952:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r194663296
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RoutedRequest.java
---
@@ -97,11 +98,17 @@ public ReferenceCounted retain(int arg0) {
@Override
public ReferenceCounted touch() {
+ if (requestAsReferenceCounted.isPresent()) {
+
ReferenceCountUtil.touch(requestAsReferenceCounted.get());
+ }
return this;
}
@Override
public ReferenceCounted touch(Object o) {
+ if (requestAsReferenceCounted.isPresent()) {
+
ReferenceCountUtil.touch(requestAsReferenceCounted.get());
--- End diff --
Shall we pass `o` to the `ReferenceCountUtil.touch` call?
> Bump Netty to 4.1
> -----------------
>
> Key: FLINK-3952
> URL: https://issues.apache.org/jira/browse/FLINK-3952
> Project: Flink
> Issue Type: Improvement
> Components: Core, Network
> Reporter: rektide de la fey
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of
> significant
> enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html], and in
> particular I find HTTP/2 codecs to be incredibly desirable to have.
> Additionally, hopefully, the [Hadoop patches for Netty
> 4.1|https://issues.apache.org/jira/browse/HADOOP-11716] get some tests and
> get merged, & I believe if/when that happens it'll be important for Flink to
> also be using the new Netty minor version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
