[GitHub] flink pull request #6156: [FLINK-9572] Extend InternalAppendingState with in...

[sihuazhou]

Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6156#discussion_r194795632
  
    --- Diff: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
 ---
    @@ -237,4 +242,16 @@ public void addAll(List<V> values) throws Exception {
     
                return keySerializationStream.toByteArray();
        }
    +
    +   @Override
    +   public List<V> getInternal() {
    +           List<V> list = new ArrayList<>();
    +           get().forEach(list::add);
    --- End diff --
    
    There seems could be NPE here, cause `get()` may return `null`.


---