[ https://issues.apache.org/jira/browse/FLINK-9580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512530#comment-16512530 ]
ASF GitHub Bot commented on FLINK-9580: --------------------------------------- GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6166 [FLINK-9580] Potentially unclosed ByteBufInputStream in RestClient##readRawResponse ## What is the purpose of the change *This pull request fixed potentially stream connection leak* ## Brief change log - *Add finally block to close specific input stream* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) You can merge this pull request into a Git repository by running: $ git pull https://github.com/yanghua/flink FLINK-9580 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6166.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6166 ---- commit f5590d2e9053282a19c8fe808cd368d40ef54787 Author: yanghua <yanghua1127@...> Date: 2018-06-14T08:16:20Z [FLINK-9580] Potentially unclosed ByteBufInputStream in RestClient#readRawResponse ---- > Potentially unclosed ByteBufInputStream in RestClient#readRawResponse > --------------------------------------------------------------------- > > Key: FLINK-9580 > URL: https://issues.apache.org/jira/browse/FLINK-9580 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Assignee: vinoyang > Priority: Minor > > Here is related code: > {code} > ByteBufInputStream in = new ByteBufInputStream(content); > byte[] data = new byte[in.available()]; > in.readFully(data); > {code} > In the catch block, ByteBufInputStream is not closed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)