[ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515597#comment-16515597 ]
ASF GitHub Bot commented on FLINK-9571: --------------------------------------- Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6173#discussion_r196042694 --- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java --- @@ -67,6 +79,21 @@ private static final Logger LOG = LoggerFactory.getLogger(QueryableStateClient.class); + private static final Map<Class<? extends StateDescriptor>, StateFactory> STATE_FACTORIES = + org.apache.flink.shaded.guava18.com.google.common.collect.ImmutableMap --- End diff -- We have unmodifiable map alternatives in the JDK. If there is not a good reason why we need guava here, I would suggest to solve this without this import. Even in that case, I would use import and not fully qualified classname. > Switch to internal states in StateBinder > ---------------------------------------- > > Key: FLINK-9571 > URL: https://issues.apache.org/jira/browse/FLINK-9571 > Project: Flink > Issue Type: Sub-task > Components: State Backends, Checkpointing > Affects Versions: 1.6.0 > Reporter: Andrey Zagrebin > Assignee: Andrey Zagrebin > Priority: Major > Fix For: 1.6.0 > > > The StateBinder factory for state objects is not a part of public API and it > produces in fact only internal states. > It can be changed it to produce internal state interfaces instead of public > API. > This can help to expose internal state API for internal components which use > the factory, e.g. for state TTL wrappers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)