Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6186#discussion_r196791555
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlConfig.java 
---
    @@ -0,0 +1,63 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.state.ttl;
    +
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.util.Preconditions;
    +
    +/**
    + * Configuration of state TTL logic.
    + * TODO: builder
    + */
    +public class TtlConfig {
    +   private final TtlUpdateType ttlUpdateType;
    +   private final TtlStateVisibility stateVisibility;
    +   private final TtlTimeCharacteristic timeCharacteristic;
    +   private final Time ttl;
    +
    +   public TtlConfig(
    +           TtlUpdateType ttlUpdateType,
    +           TtlStateVisibility stateVisibility,
    +           TtlTimeCharacteristic timeCharacteristic,
    +           Time ttl) {
    +           Preconditions.checkNotNull(ttlUpdateType);
    +           Preconditions.checkNotNull(stateVisibility);
    +           Preconditions.checkNotNull(timeCharacteristic);
    --- End diff --
    
    Why not checking for `ttl`?


---

Reply via email to