Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6189#discussion_r197062277
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -145,12 +157,43 @@ public void shutdown(Time timeout) {
}
}
- public <M extends MessageHeaders<R, P, U>, U extends MessageParameters,
R extends RequestBody, P extends ResponseBody> CompletableFuture<P>
sendRequest(String targetAddress, int targetPort, M messageHeaders, U
messageParameters, R request) throws IOException {
+ public <M extends MessageHeaders<R, P, U>, U extends MessageParameters,
R extends RequestBody, P extends ResponseBody> CompletableFuture<P> sendRequest(
+ String targetAddress,
+ int targetPort,
+ M messageHeaders,
+ U messageParameters,
+ R request) throws IOException {
+ return internalSendRequest(targetAddress, targetPort,
messageHeaders, messageParameters, request, false, new DefaultProcessor());
+ }
+
+ public <M extends MessageHeaders<R, P, U>, U extends MessageParameters,
R extends RequestBody, P extends ResponseBody> CompletableFuture<P> sendRequest(
+ String targetAddress,
+ int targetPort,
+ M messageHeaders,
+ U messageParameters,
+ R request,
+ Collection<FileUpload> fileUploads) throws IOException {
+ if (fileUploads.isEmpty()) {
+ return sendRequest(targetAddress, targetPort,
messageHeaders, messageParameters, request);
--- End diff --
here we should call `internalSendRequest(..., false, new
DefaultProcessor())`
---
