[ 
https://issues.apache.org/jira/browse/FLINK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519150#comment-16519150
 ] 

ASF GitHub Bot commented on FLINK-9633:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/6194

    [FLINK-9633][checkpoint] Use savepoint path's file system to create 
checkpoint output stream

    ## What is the purpose of the change
    
    *This PR fixes Flink doesn't use the savepoint path's filesystem to create 
the output stream on TM side.*
    
    ## Brief change log
    
      - *Use Savepoint path's file system to create checkpoint output stream.*
    
    
    ## Verifying this change
    
      - *Added 
`StreamTaskTest#testTriggerSavepointWhenTheFileSystemIsDifferentWithCheckpoint()`
 to verify the changes*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink FLINK-9633

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6194
    
----
commit f006416f652485bd59124a57774fdeaafa81824b
Author: sihuazhou <summerleafs@...>
Date:   2018-06-21T09:42:54Z

    Use Savepoint path's file system to create checkpoint output stream.

----


> Flink doesn't use the Savepoint path's filesystem to create the OuptutStream 
> on Task.
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-9633
>                 URL: https://issues.apache.org/jira/browse/FLINK-9633
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.0, 1.5.1
>
>
> Currently, flink use the Savepoint's filesystem to create the meta output 
> stream in CheckpointCoordinator(JM side), but in StreamTask(TM side) it uses 
> the Checkpoint's filesystem to create the checkpoint data output stream. When 
> the Savepoint & Checkpoint in different filesystem this will lead to 
> problematic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to