[
https://issues.apache.org/jira/browse/FLINK-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519206#comment-16519206
]
ASF GitHub Bot commented on FLINK-9599:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6178#discussion_r197085237
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java
---
@@ -151,18 +143,26 @@ protected void channelRead0(final
ChannelHandlerContext ctx, final HttpObject ms
ctx.fireChannelRead(msg);
}
} catch (Exception e) {
- HttpRequest tmpRequest = currentHttpRequest;
- deleteUploadedFiles();
- reset();
- LOG.warn("Internal server error. File upload failed.",
e);
- HandlerUtils.sendErrorResponse(
- ctx,
- tmpRequest,
- new ErrorResponseBody("File upload failed."),
- HttpResponseStatus.INTERNAL_SERVER_ERROR,
- Collections.emptyMap()
- );
+ handleError(ctx, "File upload failed.",
HttpResponseStatus.INTERNAL_SERVER_ERROR, e);
+ }
+ }
+
+ private void handleError(ChannelHandlerContext ctx, String
errorMessage, HttpResponseStatus responseStatus, @Nullable Throwable e) {
+ HttpRequest tmpRequest = currentHttpRequest;
+ deleteUploadedFiles();
+ reset();
+ if (e == null) {
+ LOG.warn(errorMessage);
+ } else {
+ LOG.warn(errorMessage, e);
--- End diff --
but this will also print "null", won't it? That's what i was trying to
avoid here.
> Implement generic mechanism to receive files via rest
> -----------------------------------------------------
>
> Key: FLINK-9599
> URL: https://issues.apache.org/jira/browse/FLINK-9599
> Project: Flink
> Issue Type: New Feature
> Components: REST
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> As a prerequisite for a cleaner implementation of FLINK-9280 we should
> * extend the RestClient to allow the upload of Files
> * extend FileUploadHandler to accept mixed multi-part requests (json + files)
> * generalize mechanism for accessing uploaded files in {{AbstractHandler}}
> Uploaded files can be forwarded to subsequent handlers as an attribute,
> similar to the existing special case for the {{JarUploadHandler}}. The JSON
> body can be forwarded by replacing the incoming http requests with a simple
> {{DefaultFullHttpRequest}}.
> Uploaded files will be retrievable through the {{HandlerRequest}}.
> I'm not certain if/how we can document that a handler accepts files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
