[ 
https://issues.apache.org/jira/browse/FLINK-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521365#comment-16521365
 ] 

ASF GitHub Bot commented on FLINK-9642:
---------------------------------------

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/6205
  
    Hi, @Aitozi Could you please take a look on the travis error 
    
    ```
    Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec 
<<< FAILURE! - in org.apache.flink.cep.nfa.NFAStateAccessTest
    testIterativeWithABACPattern(org.apache.flink.cep.nfa.NFAStateAccessTest)  
Time elapsed: 0.009 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<20> but was:<8>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at 
org.apache.flink.cep.nfa.NFAStateAccessTest.testIterativeWithABACPattern(NFAStateAccessTest.java:193)
    
    
testComplexBranchingAfterZeroOrMore(org.apache.flink.cep.nfa.NFAStateAccessTest)
  Time elapsed: 0.005 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<5> but was:<2>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at 
org.apache.flink.cep.nfa.NFAStateAccessTest.testComplexBranchingAfterZeroOrMore(NFAStateAccessTest.java:112)
    
    Running org.apache.flink.cep.nfa.compiler.NFACompilerTest
    Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec - 
in org.apache.flink.cep.nfa.compiler.NFACompilerTest
    Running org.apache.flink.cep.nfa.DeweyNumberTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec - 
in org.apache.flink.cep.nfa.DeweyNumberTest
    Running org.apache.flink.cep.nfa.sharedbuffer.SharedBufferTest
    Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - 
in org.apache.flink.cep.nfa.sharedbuffer.SharedBufferTest
    Running org.apache.flink.cep.pattern.PatternTest
    Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 sec 
- in org.apache.flink.cep.pattern.PatternTest
    
    Results :
    
    Failed tests: 
      NFAStateAccessTest.testComplexBranchingAfterZeroOrMore:112 expected:<5> 
but was:<2>
      NFAStateAccessTest.testIterativeWithABACPattern:193 expected:<20> but 
was:<8>
    
    Tests run: 80, Failures: 2, Errors: 0, Skipped: 12
    
    13:21:32.852 [INFO] 
------------------------------------------------------------------------
    13:21:32.852 [INFO] Reactor Summary:
    13:21:32.852 [INFO] 
    13:21:32.852 [INFO] flink-queryable-state-client-java .................. 
SUCCESS [  4.830 s]
    13:21:32.852 [INFO] flink-cep .......................................... 
FAILURE [  5.861 s]
    13:21:32.852 [INFO] flink-table ........................................ 
SKIPPED
    13:21:32.852 [INFO] flink-queryable-state-runtime ...................... 
SKIPPED
    13:21:32.852 [INFO] flink-gelly ........................................ 
SKIPPED
    13:21:32.852 [INFO] flink-gelly-scala .................................. 
SKIPPED
    13:21:32.852 [INFO] flink-gelly-examples ............................... 
SKIPPED
    13:21:32.852 [INFO] flink-python ....................................... 
SKIPPED
    13:21:32.852 [INFO] flink-ml ........................................... 
SKIPPED
    13:21:32.852 [INFO] flink-cep-scala .................................... 
SKIPPED
    ```


> Reduce the count to deal with state during a CEP process 
> ---------------------------------------------------------
>
>                 Key: FLINK-9642
>                 URL: https://issues.apache.org/jira/browse/FLINK-9642
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.6.0
>            Reporter: aitozi
>            Assignee: aitozi
>            Priority: Major
>              Labels: pull-request-available
>
> With the rework of sharedBuffer Flink-9418, the lock & release operation is 
> deal with rocksdb state which is different from the previous version which 
> will read the state of sharedBuffer all to memory, i think we can add a cache 
> or variable in sharedbuffer to cache the LockAble Object to mark the ref 
> change in once process in NFA, this will reduce the count when the events 
> point to the same NodeId.. And flush the result to MapState at the end of 
> process. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to