[
https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522140#comment-16522140
]
ASF GitHub Bot commented on FLINK-6469:
---------------------------------------
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r197754848
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java ---
@@ -148,6 +148,27 @@ public static MemorySize parse(String text) throws
IllegalArgumentException {
return new MemorySize(parseBytes(text));
}
+ /**
+ * Parses the given string as as MemorySize.
+ * The supported expressions are listed under {@link MemorySize}.
+ *
+ * <p>
+ * Note : this method is compatible with the old memory config key,
like {@link TaskManagerOptions#MANAGED_MEMORY_SIZE}.
+ * </p>
+ *
+ * @param text The string to parse.
+ * @return The parsed MemorySize.
+ *
+ * @throws IllegalArgumentException Thrown, if the expression cannot be
parsed.
+ */
+ public static MemorySize parseAsMebiBytesIfNoUnit(String text) throws
IllegalArgumentException {
--- End diff --
@dawidwys there is not a `MemoryUnit` and `parseAsMebiBytesIfNoUnit` just
for MebiBytes(`taskmanager.memory.size`) so I think we should not make it more
complex.
> Configure Memory Sizes with units
> ---------------------------------
>
> Key: FLINK-6469
> URL: https://issues.apache.org/jira/browse/FLINK-6469
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> Currently, memory sizes are configured by pure numbers, the interpretation is
> different from configuration parameter to parameter.
> For example, heap sizes are configured in megabytes, network buffer memory is
> configured in bytes, alignment thresholds are configured in bytes.
> I propose to configure all memory parameters the same way, with units similar
> to time. The JVM itself configured heap size similarly: {{Xmx5g}} or
> {{Xmx2000m}}.
> {code}
> 10000 -> bytes
> 10 kb
> 64 mb
> 1 gb
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
