[
https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524000#comment-16524000
]
ASF GitHub Bot commented on FLINK-8866:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6201#discussion_r198146766
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/connector/TableConnectorFactoryService.scala
---
@@ -141,22 +143,26 @@ object TableSourceFactoryService extends Logging {
// check for supported properties
plainProperties.foreach { k =>
- if (!supportedProperties.contains(k)) {
+ if (!k.equals(TableDescriptorValidator.TABLE_TYPE) &&
!supportedProperties.contains(k)) {
throw new ValidationException(
s"Table factory '${factory.getClass.getCanonicalName}' does not
support the " +
- s"property '$k'. Supported properties are: \n" +
-
s"${supportedProperties.map(DescriptorProperties.toString).mkString("\n")}")
+ s"property '$k'. Supported properties are: \n" +
+
s"${supportedProperties.map(DescriptorProperties.toString).mkString("\n")}")
}
}
- // create the table source
+ // create the table connector
try {
factory.create(properties.asJava)
} catch {
case t: Throwable =>
throw new TableException(
- s"Table source factory '${factory.getClass.getCanonicalName}'
caused an exception.",
+ s"Table connector factory '${factory.getClass.getCanonicalName}'
caused an exception.",
--- End diff --
There are more exception messages in this class that need an update.
> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>
> Key: FLINK-8866
> URL: https://issues.apache.org/jira/browse/FLINK-8866
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> Similar to the efforts done in FLINK-8240. We need unified ways to configure
> and instantiate TableSinks. Among other applications, this is necessary in
> order to declare table sinks in an environment file of the SQL client. Such
> that the sink can be used for {{INSERT INTO}} statements.
> Below are a few major changes in mind.
> 1) Add TableSinkFactory/TableSinkFactoryService similar to
> TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both)
> for both TableSource and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to
> identify whether it's source or sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
