[ https://issues.apache.org/jira/browse/FLINK-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526528#comment-16526528 ]
ASF GitHub Bot commented on FLINK-9672: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6213#discussion_r198912529 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -322,9 +322,6 @@ private JobManagerRunner createJobManagerRunner(JobGraph jobGraph) throws Except @Override public CompletableFuture<Collection<JobID>> listJobs(Time timeout) { - if (jobManagerRunners.isEmpty()) { --- End diff -- nice > Fail fatally if we cannot submit job on added JobGraph signal > ------------------------------------------------------------- > > Key: FLINK-9672 > URL: https://issues.apache.org/jira/browse/FLINK-9672 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination > Affects Versions: 1.5.0, 1.6.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Critical > Labels: pull-request-available > Fix For: 1.6.0, 1.5.1 > > > The {{SubmittedJobGraphStore}} signals when new {{JobGraphs}} are added. If > this happens, then the leader should recover this job and submit it. If the > recovery/submission should fail for some reason, then we should fail fatally > to restart the process which will then try to recover the jobs again. -- This message was sent by Atlassian JIRA (v7.6.3#76005)