[
https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526534#comment-16526534
]
ASF GitHub Bot commented on FLINK-9456:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6132#discussion_r198491333
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java
---
@@ -278,4 +279,13 @@ void heartbeatFromTaskManager(
* not available (yet).
*/
CompletableFuture<OperatorBackPressureStatsResponse>
requestOperatorBackPressureStats(JobVertexID jobVertexId);
+
+ /**
+ * Notifies that the task manager has terminated.
+ *
+ * @param resourceID identifying the task manager
+ * @param allocationIDs held by this job that belong to the task manager
+ * @param cause of the task manager termination
+ */
+ void taskManagerTerminated(ResourceID resourceID, Set<AllocationID>
allocationIDs, Exception cause);
--- End diff --
methods should usually be a verb. What about `notifyTaskManagerTermination`?
> Let ResourceManager notify JobManager about failed/killed TaskManagers
> ----------------------------------------------------------------------
>
> Key: FLINK-9456
> URL: https://issues.apache.org/jira/browse/FLINK-9456
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Sihua Zhou
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0, 1.5.1
>
>
> Often, the {{ResourceManager}} learns faster about TaskManager
> failures/killings because it directly communicates with the underlying
> resource management framework. Instead of only relying on the
> {{JobManager}}'s heartbeat to figure out that a {{TaskManager}} has died, we
> should additionally send a signal from the {{ResourceManager}} to the
> {{JobManager}} if a {{TaskManager}} has died. That way, we can react faster
> to {{TaskManager}} failures and recover our running job/s.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
