Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6186#discussion_r199109435
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlMapState.java 
---
    @@ -0,0 +1,134 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.state.ttl;
    +
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.runtime.state.internal.InternalMapState;
    +import org.apache.flink.util.FlinkRuntimeException;
    +
    +import java.util.AbstractMap;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.Iterator;
    +import java.util.Map;
    +import java.util.stream.Stream;
    +import java.util.stream.StreamSupport;
    +
    +/**
    + * This class wraps map state with TTL logic.
    + *
    + * @param <K> The type of key the state is associated to
    + * @param <N> The type of the namespace
    + * @param <UK> Type of the user entry key of state with TTL
    + * @param <UV> Type of the user entry value of state with TTL
    + */
    +class TtlMapState<K, N, UK, UV>
    +   extends AbstractTtlState<K, N, Map<UK, UV>, Map<UK, TtlValue<UV>>, 
InternalMapState<K, N, UK, TtlValue<UV>>>
    +   implements InternalMapState<K, N, UK, UV> {
    +   TtlMapState(
    +           InternalMapState<K, N, UK, TtlValue<UV>> original,
    +           TtlConfig config,
    +           TtlTimeProvider timeProvider,
    +           TypeSerializer<Map<UK, UV>> valueSerializer) {
    +           super(original, config, timeProvider, valueSerializer);
    +   }
    +
    +   @Override
    +   public UV get(UK key) throws Exception {
    +           return getWithTtlCheckAndUpdate(() -> original.get(key), v -> 
original.put(key, v), () -> original.remove(key));
    +   }
    +
    +   @Override
    +   public void put(UK key, UV value) throws Exception {
    +           original.put(key, wrapWithTs(value));
    +   }
    +
    +   @Override
    +   public void putAll(Map<UK, UV> map) throws Exception {
    +           if (map == null) {
    +                   return;
    +           }
    +           Map<UK, TtlValue<UV>> ttlMap = new HashMap<>();
    --- End diff --
    
    We can already initialize the new map with `map.size()`.


---

Reply via email to