[
https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527379#comment-16527379
]
ASF GitHub Bot commented on FLINK-8866:
---------------------------------------
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6201
@suez1224 Yes sounds good to me. Only `from-field` timestamps matter right
now.
We should also think of the opposite of a timestamps extractor (timestamp
inserter) for cases where the rowtime needs some preprocessing (like e.g.
concatenation of a DATE and TIME column), but we can deal with such cases in a
follow up issue.
A helper method would be useful. We already have something similar in
`SchemaValidator` for schema derivation.
> Create unified interfaces to configure and instatiate TableSinks
> ----------------------------------------------------------------
>
> Key: FLINK-8866
> URL: https://issues.apache.org/jira/browse/FLINK-8866
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Shuyi Chen
> Priority: Major
> Labels: pull-request-available
>
> Similar to the efforts done in FLINK-8240. We need unified ways to configure
> and instantiate TableSinks. Among other applications, this is necessary in
> order to declare table sinks in an environment file of the SQL client. Such
> that the sink can be used for {{INSERT INTO}} statements.
> Below are a few major changes in mind.
> 1) Add TableSinkFactory/TableSinkFactoryService similar to
> TableSourceFactory/TableSourceFactoryService
> 2) Add a common property called "type" with values (source, sink and both)
> for both TableSource and TableSink.
> 3) in yaml file, replace "sources" with "tables", and use tableType to
> identify whether it's source or sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
