Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6222#discussion_r199170250
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java
 ---
    @@ -66,6 +67,9 @@ public JobSubmitHandler(
                }
     
                return gateway.submitJob(jobGraph, timeout)
    -                   .thenApply(ack -> new JobSubmitResponseBody("/jobs/" + 
jobGraph.getJobID()));
    +                   .thenApply(ack -> new JobSubmitResponseBody("/jobs/" + 
jobGraph.getJobID()))
    +                   .exceptionally(exception -> {
    +                           throw new CompletionException(new 
RestHandlerException("Job submission failed.", 
HttpResponseStatus.INTERNAL_SERVER_ERROR, exception));
    --- End diff --
    
    Maybe we could add the `exception.getMessage` to the `message` of the 
`RestHandlerException`. Otherwise the user will only see `"Job submission 
failed."` in the `ErrorResponseBody`. With the change it could be `"Job 
submission failed: Failure cause"`


---

Reply via email to