Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6226#discussion_r199209179
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/OverWindowTest.scala
 ---
    @@ -44,7 +44,26 @@ class OverWindowTest extends TableTestBase {
           "sum(DISTINCT c) OVER (PARTITION BY b ORDER BY proctime ROWS BETWEEN 
2 preceding AND " +
           "CURRENT ROW) as sum2 " +
           "from MyTable"
    -
    +    val sql2 = "SELECT " +
    --- End diff --
    
    I think we can reduce the number of tests is a bit. 
    We are basically testing Calcite's parser / validator multiple times with 
very similar queries. For example, Calcite does not distinguish between 
proctime and rowtime. One query with a `WINDOW` clause per test case should be 
sufficient.


---

Reply via email to