[ 
https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530081#comment-16530081
 ] 

ASF GitHub Bot commented on FLINK-9688:
---------------------------------------

Github user hequn8128 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6223#discussion_r199537075
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
 ---
    @@ -300,6 +300,24 @@ object FunctionGenerator {
         DOUBLE_TYPE_INFO,
         BuiltInMethods.ATAN_DEC)
     
    +  addSqlFunctionMethod(
    +    ATAN2,
    +    Seq(DOUBLE_TYPE_INFO, DOUBLE_TYPE_INFO),
    +    DOUBLE_TYPE_INFO,
    +    BuiltInMethods.ATAN2)
    +
    +  addSqlFunctionMethod(
    +    ATAN2,
    +    Seq(DOUBLE_TYPE_INFO, BIG_DEC_TYPE_INFO),
    +    DOUBLE_TYPE_INFO,
    +    BuiltInMethods.ATAN2_DEC)
    +
    +  addSqlFunctionMethod(
    +    ATAN2,
    +    Seq(BIG_DEC_TYPE_INFO, BIG_DEC_TYPE_INFO),
    +    DOUBLE_TYPE_INFO,
    +    BuiltInMethods.ATAN2_DEC)
    --- End diff --
    
    BuiltInMethods.ATAN2_DEC_DEC 


> ATAN2 Sql Function support
> --------------------------
>
>                 Key: FLINK-9688
>                 URL: https://issues.apache.org/jira/browse/FLINK-9688
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Minor
>              Labels: pull-request-available
>
> simple query fails {code}
> ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
> BatchTableEnvironment tableEnv = TableEnvironment.getTableEnvironment(env, 
> config());
> DataSet<Tuple3<Integer, Long, String>> ds = 
> CollectionDataSets.get3TupleDataSet(env);
> tableEnv.registerDataSet("t1", ds, "x, y, z");
> String sqlQuery = "SELECT atan2(1,2)";
> Table result = tableEnv.sqlQuery(sqlQuery);
> {code}
> while at the same time Calcite supports it and in Calcite's sqlline it works 
> like {noformat}
> 0: jdbc:calcite:model=target/test-classes/mod> select atan2(1,2);
> +-----------------+
> |     EXPR$0      |
> +-----------------+
> | 0.4636476090008061 |
> +-----------------+
> 1 row selected (0.173 seconds)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to