Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6245#discussion_r200040940
  
    --- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
    @@ -19,6 +19,9 @@
     
     # from scala-lang 2.10.4
     
    +# Uncomment the following line to enable remote debug
    +# export 
FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005"
    --- End diff --
    
    I don't find something like `flink-env.sh` for specify flink related env 
variable. So I just put it in `start-scala-shell.sh` directly. I don't think 
bool flag is proper, as it hide the details of remote debug info, like which 
port to listen. I believe most of apache project use `*JAVA_OPTS` for remote 
debug which is very common. What do you think ?


---

Reply via email to