[ 
https://issues.apache.org/jira/browse/FLINK-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532956#comment-16532956
 ] 

Sihua Zhou commented on FLINK-9735:
-----------------------------------

Oh [~yuzhih...@gmail.com] you are right! The case in {{RocksDBResource}} should 
be fixed, it didn't follow the OptionsFactory's java doc.

So the true issue here is not related to the code
{code:java}
    if (optionsFactory != null) {
      opt = optionsFactory.createDBOptions(opt);
    }
{code}
in {{RocksDBStateBackend}}, but for the use case in {{RocksDBResource}}. Do you 
mind if I change this ticket's description and title to the true issue.

> Potential resource leak in RocksDBStateBackend#getDbOptions
> -----------------------------------------------------------
>
>                 Key: FLINK-9735
>                 URL: https://issues.apache.org/jira/browse/FLINK-9735
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Minor
>
> Here is related code:
> {code}
>     if (optionsFactory != null) {
>       opt = optionsFactory.createDBOptions(opt);
>     }
> {code}
> opt, an DBOptions instance, should be closed before being rewritten.
> getColumnOptions has similar issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to