[ https://issues.apache.org/jira/browse/FLINK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533106#comment-16533106 ]
Ted Yu commented on FLINK-9736: ------------------------------- bq. we never call `poll()` on it. What happens to the {{peek}} call when heapOfKeyGroupHeaps is empty ? > Potential null reference in KeyGroupPartitionedPriorityQueue#poll() > ------------------------------------------------------------------- > > Key: FLINK-9736 > URL: https://issues.apache.org/jira/browse/FLINK-9736 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Assignee: vinoyang > Priority: Minor > > {code} > final PQ headList = heapOfkeyGroupedHeaps.peek(); > final T head = headList.poll(); > {code} > {{peek}} call may return null. > The return value should be checked before de-referencing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)