Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6255#discussion_r200330683
  
    --- Diff: docs/dev/table/streaming.md ---
    @@ -591,16 +589,14 @@ qConfig.withIdleStateRetentionTime(Time.hours(12);
     
     val qConfig: StreamQueryConfig = ???
     
    -// set idle state retention time: min = 12 hour, max = 16 hours
    -qConfig.withIdleStateRetentionTime(Time.hours(12), Time.hours(16))
    -// set idle state retention time. min = max = 12 hours
    -qConfig.withIdleStateRetentionTime(Time.hours(12)
    +// set idle state retention time: min = 12 hour, max = 24 hours
    +qConfig.withIdleStateRetentionTime(Time.hours(12), Time.hours(24))
     
     {% endhighlight %}
     </div>
     </div>
     
    -Configuring different minimum and maximum idle state retention times is 
more efficient because it reduces the internal book-keeping of a query for when 
to remove state.
    +Configuring different minimum and maximum idle state retention times is 
more efficient because it reduces the internal book-keeping of a query for when 
to remove state. Difference between minTime and maxTime shoud be at least 5 
minutes.
    --- End diff --
    
    The "... more efficient ..." does not apply anymore. Maybe rephrase to 
    
    > Cleaning up state requires additional bookkeeping which becomes less 
expensive for larger differences of `minTime` and `maxTime`. The difference 
between `minTime` and `maxTime` must be at least 5 minutes.
    



---

Reply via email to