[
https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533619#comment-16533619
]
ASF GitHub Bot commented on FLINK-9681:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/6255#discussion_r200333630
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/HarnessTestBase.scala
---
@@ -384,4 +386,12 @@ object HarnessTestBase {
value.row.getField(selectorField).asInstanceOf[T]
}
}
+
+ /**
+ * Test class used to test min and max retention time.
+ */
+ class StreamQueryConfigTest(min: Time, max: Time) extends
StreamQueryConfig {
--- End diff --
I would rename the class to `TestStreamQueryConfig` because the `Test` at
the end suggests that this class is testing something instead of being a util
for a test.
> Make sure minRetentionTime not equal to maxRetentionTime
> --------------------------------------------------------
>
> Key: FLINK-9681
> URL: https://issues.apache.org/jira/browse/FLINK-9681
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
> Labels: pull-request-available
>
> Currently, for a group by(or other operators), if minRetentionTime equals to
> maxRetentionTime, the group by operator will register a timer for each record
> coming at different time which cause performance problem. The reasoning for
> having two parameters is that we can avoid to register many timers if we have
> more freedom when to discard state. As min equals to max cause performance
> problem it is better to make sure these two parameters are not same.
> Any suggestions are welcome.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
