Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6267#discussion_r200480534
  
    --- Diff: 
flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/batch/sql/JavaSqlITCase.java
 ---
    @@ -73,6 +73,30 @@ public void testValues() throws Exception {
                compareResultAsText(results, expected);
        }
     
    +   @Test
    +   public void testValuesWithCast() throws Exception {
    --- End diff --
    
    Can you move this test to 
`org.apache.flink.table.runtime.batch.sql.SetOperatorsITCase` and also add one 
to `org.apache.flink.table.runtime.stream.sql.SetOperatorsITCase`?
    
    In addition it would be good to have to plan tests for this query in 
`org.apache.flink.table.api.batch.sql.SetOperatorsTest` and 
`org.apache.flink.table.api.stream.sql.SetOperatorsTest`.


---

Reply via email to