[
https://issues.apache.org/jira/browse/FLINK-9703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536875#comment-16536875
]
ASF GitHub Bot commented on FLINK-9703:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6288#discussion_r200987982
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
---
@@ -85,11 +85,11 @@
* @param taskID the taskID for this worker.
*/
public LaunchableMesosWorker(
- MesosArtifactResolver resolver,
- MesosTaskManagerParameters params,
- ContainerSpecification containerSpec,
- Protos.TaskID taskID,
- MesosConfiguration mesosConfiguration) {
+ MesosArtifactResolver resolver,
+ MesosTaskManagerParameters params,
--- End diff --
please try to avoid formatting changes.
> Mesos does not expose TM Prometheus port
> ----------------------------------------
>
> Key: FLINK-9703
> URL: https://issues.apache.org/jira/browse/FLINK-9703
> Project: Flink
> Issue Type: Bug
> Components: Mesos
> Reporter: Rune Skou Larsen
> Priority: Major
> Labels: pull-request-available
>
> LaunchableMesosWorker makes Mesos expose these ports for a Task Manager:
> {{private static final String[] TM_PORT_KEYS = {}}
> {{ "taskmanager.rpc.port",}}
> {{ "taskmanager.data.port"};}}
> But when running Prometheus Exporter on a TM, another port needs to be
> exposed to make Flink's Prometheos endpoint externally scrapable by the
> Prometheus server. By default this is port 9249, but it is configurable
> according to:
> [https://ci.apache.org/projects/flink/flink-docs-release-1.6/monitoring/metrics.html#prometheus-orgapacheflinkmetricsprometheusprometheusreporter]
>
> My plan is to make a PR, that just adds another config option for mesos, to
> enable custom ports to be exposed in the provisioned TMs.
> I considered carrying parts of the Metrics config into the Mesos code to
> automatically map metrics ports in mesos. But making such a "shortcut"
> between Flink's metrics and mesos modules would probably need some sort of
> integration testing, so I prefer the simple solution of just adding another
> Mesos config option. But comments are welcome.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
