Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/934#discussion_r35991266
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ---
    @@ -75,24 +78,24 @@
      * The execution graph is the central data structure that coordinates the 
distributed
      * execution of a data flow. It keeps representations of each parallel 
task, each
      * intermediate result, and the communication between them.
    - *
    + * <p/>
      * The execution graph consists of the following constructs:
      * <ul>
    - *     <li>The {@link ExecutionJobVertex} represents one vertex from the 
JobGraph (usually one operation like
    - *         "map" or "join") during execution. It holds the aggregated 
state of all parallel subtasks.
    - *         The ExecutionJobVertex is identified inside the graph by the 
{@link JobVertexID}, which it takes
    - *         from the JobGraph's corresponding JobVertex.</li>
    - *     <li>The {@link ExecutionVertex} represents one parallel subtask. 
For each ExecutionJobVertex, there are
    - *         as many ExecutionVertices as the parallelism. The 
ExecutionVertex is identified by
    - *         the ExecutionJobVertex and the number of the parallel 
subtask</li>
    - *     <li>The {@link Execution} is one attempt to execute a 
ExecutionVertex. There may be multiple Executions
    - *         for the ExecutionVertex, in case of a failure, or in the case 
where some data needs to be recomputed
    - *         because it is no longer available when requested by later 
operations. An Execution is always
    - *         identified by an {@link ExecutionAttemptID}. All messages 
between the JobManager and the TaskManager
    - *         about deployment of tasks and updates in the task status always 
use the ExecutionAttemptID to
    - *         address the message receiver.</li>
    + * <li>The {@link ExecutionJobVertex} represents one vertex from the 
JobGraph (usually one operation like
    + * "map" or "join") during execution. It holds the aggregated state of all 
parallel subtasks.
    + * The ExecutionJobVertex is identified inside the graph by the {@link 
JobVertexID}, which it takes
    + * from the JobGraph's corresponding JobVertex.</li>
    + * <li>The {@link ExecutionVertex} represents one parallel subtask. For 
each ExecutionJobVertex, there are
    + * as many ExecutionVertices as the parallelism. The ExecutionVertex is 
identified by
    + * the ExecutionJobVertex and the number of the parallel subtask</li>
    + * <li>The {@link Execution} is one attempt to execute a ExecutionVertex. 
There may be multiple Executions
    + * for the ExecutionVertex, in case of a failure, or in the case where 
some data needs to be recomputed
    + * because it is no longer available when requested by later operations. 
An Execution is always
    + * identified by an {@link ExecutionAttemptID}. All messages between the 
JobManager and the TaskManager
    + * about deployment of tasks and updates in the task status always use the 
ExecutionAttemptID to
    + * address the message receiver.</li>
    --- End diff --
    
    This change seems unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to