[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537031#comment-16537031 ]
ASF GitHub Bot commented on FLINK-8558: --------------------------------------- Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r201030536 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/sources/TableSourceFactoryServiceTest.scala --- @@ -52,21 +57,33 @@ class TableSourceFactoryServiceTest { @Test(expected = classOf[ValidationException]) def testUnsupportedProperty(): Unit = { val props = properties() + props.put(CONNECTOR_TYPE, "fixed") + props.put(FORMAT_TYPE, "test") props.put("format.path_new", "/new/path") TableSourceFactoryService.findAndCreateTableSource(props.toMap) } @Test(expected = classOf[TableException]) def testFailingFactory(): Unit = { val props = properties() + props.put(CONNECTOR_TYPE, "fixed") + props.put(FORMAT_TYPE, "test") props.put("failing", "true") TableSourceFactoryService.findAndCreateTableSource(props.toMap) } + @Test + def testWildcardFormat(): Unit = { + val props = properties() + props.put(CONNECTOR_TYPE, "wildcard") + props.put(FORMAT_TYPE, "test") + props.put("format.type", "not-test") + props.put("format.not-test-property", "wildcard-property") + TableSourceFactoryService.findAndCreateTableSource(props.toMap) --- End diff -- assert what was found? > Add unified format interfaces and format discovery > -------------------------------------------------- > > Key: FLINK-8558 > URL: https://issues.apache.org/jira/browse/FLINK-8558 > Project: Flink > Issue Type: New Feature > Components: Streaming Connectors > Reporter: Timo Walther > Assignee: Timo Walther > Priority: Major > Labels: pull-request-available > > In the last release, we introduced a new module {{flink-formats}}. Currently > only {{flink-avro}} is located there but we will add more formats such as > {{flink-json}}, {{flink-protobuf}}, and so on. For better separation of > concerns we want decouple connectors from formats: e.g., remove > {{KafkaAvroTableSource}} and {{KafkaJsonTableSource}}. > A newly introduced {{FormatFactory}} will use Java service loaders to > discovery available formats in the classpath (similar to how file systems are > discovered now). A {{Format}} will provide a method for converting {{byte[]}} > to target record type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)