[
https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537116#comment-16537116
]
ASF GitHub Bot commented on FLINK-9687:
---------------------------------------
Github user Aitozi commented on the issue:
https://github.com/apache/flink/pull/6224
Get it, this change indeed will lead to the situation you mentioned.
> What are the cases where this change leads to an improvement
I just read code and think the order is not suitable.
> I think it rarely happens that a timer fires while a window is empty
I think here is not the one in fact, because we get the window content each
time before get the trigger result. AFAIK in there is `cleanupTimer` and
`fireTimer` in `internalTimerService` in `windowOperator`. we only have to get
window content for `fireTimer` of a window. In now implementation, we have to
extract both for the `cleanupTimer` and `fireTimer`.
> Delay the state fetch only when the triggerResult is fire
> ---------------------------------------------------------
>
> Key: FLINK-9687
> URL: https://issues.apache.org/jira/browse/FLINK-9687
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 1.5.0
> Reporter: aitozi
> Assignee: aitozi
> Priority: Major
> Labels: pull-request-available
>
> When the window operator is fired by the event timer or processing timer, it
> fetch the state content first. I think it only need to fetch the content from
> windowState when the triggerResult is Fire. So we have to change the order to
> avoid this cost ( the cost of fetch content from state is more than judge the
> triggerResult).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
