Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6291#discussion_r201303678
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
---
@@ -167,7 +167,8 @@ public void exceptionCaught(ChannelHandlerContext ctx,
Throwable cause) throws E
tex = new RemoteTransportException("Lost
connection to task manager '" + remoteAddr + "'. " +
"This indicates that the remote task
manager was lost.", remoteAddr, cause);
} else {
- tex = new
LocalTransportException(cause.getMessage(), ctx.channel().localAddress(),
cause);
+ final SocketAddress localAddr =
ctx.channel().localAddress();
+ tex = new
LocalTransportException(cause.getMessage() + " (connection to '" + remoteAddr +
"')", localAddr, cause);
--- End diff --
using `String.format` here looks better to me
---