Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6323#discussion_r202274951
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala
---
@@ -16,14 +16,14 @@
* limitations under the License.
*/
-package org.apache.flink.table.connectors
+package org.apache.flink.table.factories
import java.util
/**
* Common trait for all properties-based discoverable table factories.
*/
-trait DiscoverableTableFactory {
+trait TableFactory {
--- End diff --
name `TableFactory` is kind of strange. `Table` here is more like package
name and `Factory` is generic. I think I liked the previous name better,
although it wasn't also very good but it's hard for me to figure out a better
one.
---
