Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202350170
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
 ---
    @@ -103,24 +103,40 @@ abstract class BatchTableEnvironment(
         : Unit = {
     
         tableSource match {
    +
    +      // check for proper batch table source
    --- End diff --
    
    ditto, those changes do seems to not belong to this commit. If so please 
extract them to separate one:
    
    ```
    git reset --soft HEAD^
    git reset HEAD 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
    git commit -m "Clean up and simplify changes"
    git commit -a --fixup=42a8a156d4e6f8f3d119c458350b6c897306fc48 # MD5 of 
Shuyi Chen's commit
    git rebase -i origin/master --autosquash
    ```


---

Reply via email to