[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543234#comment-16543234 ]
ASF GitHub Bot commented on FLINK-8558: --------------------------------------- Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6323#discussion_r202282221 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -214,15 +216,18 @@ private static TableDescriptor createTableDescriptor(String name, Map<String, Ob if (typeObject == null || !(typeObject instanceof String)) { throw new SqlClientException("Invalid 'type' attribute for table '" + name + "'."); } - final String type = (String) config.get(TABLE_TYPE); + final String type = (String) typeObject; + final Map<String, Object> properties = new HashMap<>(config); config.remove(TABLE_TYPE); - final Map<String, String> normalizedConfig = ConfigUtil.normalizeYaml(config); - if (type.equals(TableDescriptorValidator.TABLE_TYPE_VALUE_SOURCE())) { - return new Source(name, normalizedConfig); - } else if (type.equals(TableDescriptorValidator.TABLE_TYPE_VALUE_SINK())) { - return new Sink(name, normalizedConfig); - } else if (type.equals(TableDescriptorValidator.TABLE_TYPE_VALUE_SOURCE_SINK())) { - return new SourceSink(name, normalizedConfig); + + final Map<String, String> normalizedProperties = ConfigUtil.normalizeYaml(properties); + switch (type) { + case TABLE_TYPE_VALUE_SOURCE: + return new Source(name, normalizedProperties); + case TABLE_TYPE_VALUE_SINK: + return new Sink(name, normalizedProperties); + case TABLE_TYPE_VALUE_BOTH: + return new SourceSink(name, normalizedProperties); --- End diff -- ``` default: throw new UnsupportedOperationException( String.format("Unsupported [%s] value [%s]", TABLE_TYPE, type) ``` > Add unified format interfaces and format discovery > -------------------------------------------------- > > Key: FLINK-8558 > URL: https://issues.apache.org/jira/browse/FLINK-8558 > Project: Flink > Issue Type: New Feature > Components: Streaming Connectors > Reporter: Timo Walther > Assignee: Timo Walther > Priority: Major > Labels: pull-request-available > > In the last release, we introduced a new module {{flink-formats}}. Currently > only {{flink-avro}} is located there but we will add more formats such as > {{flink-json}}, {{flink-protobuf}}, and so on. For better separation of > concerns we want decouple connectors from formats: e.g., remove > {{KafkaAvroTableSource}} and {{KafkaJsonTableSource}}. > A newly introduced {{FormatFactory}} will use Java service loaders to > discovery available formats in the classpath (similar to how file systems are > discovered now). A {{Format}} will provide a method for converting {{byte[]}} > to target record type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)