Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6328#discussion_r202505334
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ---
@@ -249,14 +326,40 @@ public static SSLContext
createSSLServerContext(Configuration sslConfig) throws
// Set up key manager factory to use the server key
store
KeyManagerFactory kmf = KeyManagerFactory.getInstance(
-
KeyManagerFactory.getDefaultAlgorithm());
+ KeyManagerFactory.getDefaultAlgorithm());
kmf.init(ks, certPassword.toCharArray());
+ return new SSLServerTools(sslProvider,
sslProtocolVersion, sslCipherSuites, kmf);
+ }
+
+ return null;
+ }
+
+ /**
+ * Creates the SSL Context for the server if SSL is configured.
+ *
+ * @param sslConfig
+ * The application configuration
+ * @return The SSLContext object which can be used by the ssl transport
server
+ * Returns null if SSL is disabled
+ * @throws Exception
+ * Thrown if there is any misconfiguration
+ */
+ @Nullable
+ public static SSLContext createSSLServerContext(Configuration
sslConfig) throws Exception {
+
--- End diff --
this empty line is useless, can be removed
---
