Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6333#discussion_r202552563
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java
 ---
    @@ -264,6 +265,42 @@ public void writeMappingsInKeyGroup(@Nonnull 
DataOutputView dov, int keyGroupId)
                }
        }
     
    +   public static <T> StateSnapshotKeyGroupReader 
createKeyGroupPartitionReader(
    +           @Nonnull ElementReaderFunction<T> readerFunction,
    +           @Nonnull KeyGroupElementsConsumer<T> elementConsumer) {
    --- End diff --
    
    Indenting these parameter one more level would help to distinguish the body 
from the parameter list.


---

Reply via email to