[
https://issues.apache.org/jira/browse/FLINK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545204#comment-16545204
]
ASF GitHub Bot commented on FLINK-9748:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6342
[FLINK-9748][release] Use dedicated directory for release artifacts
## What is the purpose of the change
With this PR artifacts created during the release process are no longer
placed in the root flink directory, but instead a dedicated directory under
`/tools/releasing`.
This makes it easier to reset the repository state in case of an error, as
all you have to do is remove said directory. It also prevents accidentally
committing release files.
In case of success this directory will contain all release artifacts that
should be uploaded.
Additionally this PR introduces variables for commonly used directories
(flink root directory, release directory, flink-clone directory) and reduces
usages of relative paths.
## Brief change log
* modifies source/binary release scripts to use dedicate directory for
storing release artifacts
* modified rat-plugin to exclude release directory
* modified .gitignore to exclude release directory
## Verifying this change
Manually verified.
@aljoscha @tillrohrmann I'd appreciate your input.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9748
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6342
----
commit 92bf5ce764dafa82fcdc2ad3c625d194979c76d9
Author: zentol <chesnay@...>
Date: 2018-07-16T13:16:19Z
[FLINK-9748][release] Use dedicated directory for release artifacts
----
> create_source_release pollutes flink root directory
> ---------------------------------------------------
>
> Key: FLINK-9748
> URL: https://issues.apache.org/jira/browse/FLINK-9748
> Project: Flink
> Issue Type: Improvement
> Components: Release System
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> The {{create_source_release.sh}} moves generated files into the root
> directory of the flink repository, and also creates the flink-clone in this
> directory.
> It would be nicer if these files were placed under a dedicated directory (say
> releasing/release).
> This would prevent file to prevent release files from accidentally being
> committed by adding this directory to the {{.gitignore}} file, and makes it
> easier to cleanup a failed release attempt by actually making it obvious
> which files belong to the release.
> I already implemented these changes in the {{flink-shaded}} release scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
