[ 
https://issues.apache.org/jira/browse/FLINK-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545324#comment-16545324
 ] 

ASF GitHub Bot commented on FLINK-9013:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6294#discussion_r202719580
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
 ---
    @@ -65,7 +65,11 @@
                key("yarn.containers.vcores")
                .defaultValue(-1)
                .withDescription("The number of virtual cores (vcores) per YARN 
container. By default, the number of vcores" +
    -                   " is set to the number of slots per TaskManager, if 
set, or to 1, otherwise.");
    +                   " is set to the number of slots per TaskManager, if 
set, or to 1, otherwise. In order for this parameter " +
    +                   "to be used your cluster must have CPU scheduling 
enabled. You can do this e.g. by setting the " +
    +                   
"org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler or 
enabling " +
    +                   
"org.apache.hadoop.yarn.util.resource.DominantResourceCalculator for " +
    +                   
"org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler");
    --- End diff --
    
    Have you actually tried - back when I created this issue, simply changing 
to `DominantResourceCalculator` did not lead to the desired effect.


> Document yarn.containers.vcores only being effective when adapting YARN config
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-9013
>                 URL: https://issues.apache.org/jira/browse/FLINK-9013
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, YARN
>    Affects Versions: 1.5.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2
>
>
> Even after specifying {{yarn.containers.vcores}} and having Flink request 
> such a container from YARN, it may not take these into account at all and 
> return a container with 1 vcore.
> The YARN configuration needs to be adapted to take the vcores into account, 
> e.g. by setting the {{FairScheduler}} in {{yarn-site.xml}}:
> {code}
> <property>
>   <name>yarn.resourcemanager.scheduler.class</name>
>   
> <value>org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler</value>
> </property>
> {code}
> This fact should be documented at least at the configuration parameter 
> documentation of  {{yarn.containers.vcores}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to