Github user JTaky commented on a diff in the pull request:
https://github.com/apache/flink/pull/6284#discussion_r202756536
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
---
@@ -250,6 +250,10 @@ public static Configuration
generateTaskManagerConfiguration(
cfg.setInteger(TaskManagerOptions.NUM_TASK_SLOTS,
numSlots);
}
+ if (!baseConfig.containsKey(CoreOptions.TMP_DIRS_OVERRIDDEN)){
+ cfg.setString(CoreOptions.TMP_DIRS, ""); //
HACK: emulate removal for the given key
+ }
--- End diff --
Agree, magic values are the dirtiest way.
Will go with a 'clear' (probably remove, in order to mimic java collection
API) method.
Didn't get the point with clone method. Is it in order to factorize this 4
lines or do you want to make it generic and use for all custom settings? In
such case we should extract list of predicates per each configuration which
looks quite complex as an API
---
