[ 
https://issues.apache.org/jira/browse/FLINK-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546007#comment-16546007
 ] 

ASF GitHub Bot commented on FLINK-9869:
---------------------------------------

GitHub user tison1 opened a pull request:

    https://github.com/apache/flink/pull/6345

    [FLINK-9869] Send PartitionInfo in batch to Improve perfornance

    ## What is the purpose of the change
    
    Current we send partition info as soon as one arrive. we could 
`cachePartitionInfo` and then `sendPartitionInfoAsync`, which will improve 
performance.
    
    ... also improve task deployment
    
    ## Brief change log
    
    - `Execution`
      - now deploy task in another thread
      - as describe above, now we first `cachePartitionInfo` and then 
`sendPartitionInfoAsync`
    - add a config option 
`JobManagerOptions#UPDATE_PARTITION_INFO_SEND_INTERVAL`, which config the time 
window for cachePartitionInfo
    - update `ExecutionGraphDeploymentTest` and 
`ExecutionVertexDeploymentTest`, which also tests changes above
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as 
`ExecutionGraphDeploymentTest` and `ExecutionVertexDeploymentTest`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no, it's internal)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tison1/flink partition-improve

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6345
    
----
commit ca9ffbb99e91a8415d7469cba4bf2075615edc0d
Author: 陈梓立 <wander4096@...>
Date:   2018-07-17T04:11:36Z

    [FLINK-9869] Send PartitionInfo in batch to Improve perfornance

----


> Send PartitionInfo in batch to Improve perfornance
> --------------------------------------------------
>
>                 Key: FLINK-9869
>                 URL: https://issues.apache.org/jira/browse/FLINK-9869
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 1.5.1
>            Reporter: 陈梓立
>            Assignee: 陈梓立
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2
>
>
> ... current we send partition info as soon as one arrive. we could 
> `cachePartitionInfo` and then `sendPartitionInfoAsync`, which will improve 
> performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to