[ https://issues.apache.org/jira/browse/FLINK-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546308#comment-16546308 ]
ASF GitHub Bot commented on FLINK-9852: --------------------------------------- Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6343#discussion_r202915534 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/EnvironmentTest.java --- @@ -40,10 +41,18 @@ @Test public void testMerging() throws Exception { - final Environment env1 = EnvironmentFileUtil.parseUnmodified(DEFAULTS_ENVIRONMENT_FILE); + final Map<String, String> replaceVars1 = new HashMap<>(); + replaceVars1.put("$VAR_UPDATE_MODE", "update-mode: append"); + final Environment env1 = EnvironmentFileUtil.parseModified( + DEFAULTS_ENVIRONMENT_FILE, + replaceVars1); + + final Map<String, String> replaceVars2 = new HashMap<>(); --- End diff -- ``` final Map<String, String> replaceVars2 = new HashMap<>(replaceVars1); ``` and you can drop the line below > Expose descriptor-based sink creation in table environments > ----------------------------------------------------------- > > Key: FLINK-9852 > URL: https://issues.apache.org/jira/browse/FLINK-9852 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL > Reporter: Timo Walther > Assignee: Timo Walther > Priority: Major > Labels: pull-request-available > > Currently, only a table source can be created using the unified table > descriptors with {{tableEnv.from(...)}}. A similar approach should be > supported for defining sinks or even both types at the same time. > I suggest the following syntax: > {code} > tableEnv.connect(Kafka(...)).registerSource("name") > tableEnv.connect(Kafka(...)).registerSink("name") > tableEnv.connect(Kafka(...)).registerSourceAndSink("name") > {code} > A table could then access the registered source/sink. -- This message was sent by Atlassian JIRA (v7.6.3#76005)