Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6343#discussion_r202964715 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchematicDescriptor.scala --- @@ -19,14 +19,17 @@ package org.apache.flink.table.descriptors /** - * Common class for all descriptors describing a table sink. + * A trait for descriptors that allow to define a format and schema. */ -abstract class TableSinkDescriptor extends TableDescriptor { +trait SchematicDescriptor extends Descriptor { --- End diff -- are you using it anywhere as interface? what does extracting it to separate interface give us? Maybe drop it?
---