Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6330#discussion_r203309580 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunRequestBody.java --- @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.webmonitor.handlers; + +import org.apache.flink.runtime.rest.messages.RequestBody; + +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonIgnore; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonInclude; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty; + +import javax.annotation.Nullable; + +/** + * {@link RequestBody} for running a jar. + */ +@JsonInclude(JsonInclude.Include.NON_NULL) +public class JarRunRequestBody implements RequestBody { + + private static final String FIELD_NAME_ENTRY_CLASS = "entryClass"; + private static final String FIELD_NAME_PROGRAM_ARGUMENTS = "programArgs"; + private static final String FIELD_NAME_PARALLELISM = "parallelism"; + private static final String FIELD_NAME_ALLOW_NON_RESTORED_STATE = "allowNonRestoredState"; + private static final String FIELD_NAME_SAVEPOINT_PATH = "savepointPath"; + + @JsonProperty(FIELD_NAME_ENTRY_CLASS) + @Nullable + private String entryClassName; + + @JsonProperty(FIELD_NAME_PROGRAM_ARGUMENTS) + @Nullable + private String programArguments; + + @JsonProperty(FIELD_NAME_PARALLELISM) + @Nullable + private Integer parallelism; + + @JsonProperty(FIELD_NAME_ALLOW_NON_RESTORED_STATE) + @Nullable + private Boolean allowNonRestoredState; + + @JsonProperty(FIELD_NAME_SAVEPOINT_PATH) + @Nullable + private String savepointPath; + + public JarRunRequestBody() { + this(null, null, null, null, null); + } + + @JsonCreator + public JarRunRequestBody( + @JsonProperty(FIELD_NAME_ENTRY_CLASS) String entryClassName, + @JsonProperty(FIELD_NAME_PROGRAM_ARGUMENTS) String programArguments, + @JsonProperty(FIELD_NAME_PARALLELISM) Integer parallelism, + @JsonProperty(FIELD_NAME_ALLOW_NON_RESTORED_STATE) Boolean allowNonRestoredState, + @JsonProperty(FIELD_NAME_SAVEPOINT_PATH) String savepointPath) { --- End diff -- For example, if only a partial body is sent some fields may be null. I couldn't quickly find a way to allow either all fields or non to be null.
---