GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/6363
[FLINK-9860][REST] fix buffer leak in FileUploadHandler
## What is the purpose of the change
The current implementation of `FileUploadHandler` has two cases where the
given message was not released or forwarded for some other handler to release.
## Brief change log
- change the use of SimpleChannelInboundHandler to auto-release objects and
make sure we retain them only when needed
## Verifying this change
This change added tests and can be verified as follows:
- adapted `FileUploadHandlerTest` to use a customized (Netty) leak detector
that does not only log but fails with an assertion
- enable `ERROR` logging level for
`log4j.logger.org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector`
in all unit tests in `flink-runtime` - the leak detector will otherwise not
report anything
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-9860
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6363
----
----
---
