[ https://issues.apache.org/jira/browse/FLINK-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547917#comment-16547917 ]
ASF GitHub Bot commented on FLINK-9886: --------------------------------------- GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/6366 [FLINK-9886] [sql-client] Build SQL jars with every build ## What is the purpose of the change This enables the building of the SQL jars by default. This solves a couple of issues: - Reduces user confusion for finding SQL jars in SNAPSHOT releases - Enables end-to-end testing ## Brief change log - Building enabled by defaul but can be skipped with `-DskipSqlJars` ## Verifying this change This change is a trivial rework / code cleanup without any test coverage ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): yes - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not documented You can merge this pull request into a Git repository by running: $ git pull https://github.com/twalthr/flink FLINK-9886 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6366.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6366 ---- commit 1fcf364c1b28b29fd9a346ec981b9945507f7f60 Author: Timo Walther <twalthr@...> Date: 2018-07-18T11:30:28Z [FLINK-9886] [sql-client] Build SQL jars with every build ---- > Build SQL jars with every build > ------------------------------- > > Key: FLINK-9886 > URL: https://issues.apache.org/jira/browse/FLINK-9886 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Timo Walther > Assignee: Timo Walther > Priority: Major > Labels: pull-request-available > > Currently, the shaded fat jars for SQL are only built in the {{-Prelease}} > profile. However, end-to-end tests require those jars and should also be able > to test them. E.g. existing {{META-INF}} entry and proper shading. We should > build them with every release. If a build should happen quicker one can use > the {{-Pfast}} profile. -- This message was sent by Atlassian JIRA (v7.6.3#76005)