[ 
https://issues.apache.org/jira/browse/FLINK-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552933#comment-16552933
 ] 

ASF GitHub Bot commented on FLINK-9296:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/6393

    [FLINK-9296] [table] Add support for non-windowed DISTINCT aggregates.

    ## What is the purpose of the change
    
    - Fix a regression from 1.5 that was caused by rearranging optimization 
rules.
    - Add tests to ensure the feature won't be broken again.
    
    ## Brief change log
    
    - Remove DISTINCT limitation on `DataStreamAggregateRule`.
    - Add plan test to ensure queries are correctly translated
    - Add ITCase to ensure queries are correctly executed
    - Remove outdated limitation from documentation
    
    ## Verifying this change
    
    - Run the added tests
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink table-distinctGroupBy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6393
    
----

----


> Support distinct aggregation on non-windowed grouped streaming tables
> ---------------------------------------------------------------------
>
>                 Key: FLINK-9296
>                 URL: https://issues.apache.org/jira/browse/FLINK-9296
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to